Fix libdns::Record to dnsmadeeasy::Record translation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've verified that this works alongside my parallel pull request John-K/dnsmadeeasy#4 by running the following xcaddy command: The resulting binary successfully obtains certs using the DNS01 challenge on DNSMadeEasy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when DNSMadeEasy tweaked their API, but there are now several incompatibilities with the module as it exists. Specifically:
dmeRecordFromRecordwill now set a default value of 120 if the value is 0.GtdLocationfrom the possible valuesDEFAULT, US_EAST, US_WEST, EUROPE, ASIA_PAC, OCREANIA, SOUTH_AMERICA. We set it toDEFAULT.record.ID, we translate it to 0 in the dmeRecord struct, so it will properly be omitted thanks to thejson:"id,omitempty"tag on the dmeRecord.ID item.